chore: fix route matching priority example#3889
Open
ihor-av wants to merge 1 commit into
Open
Conversation
The current "Route matching priority" example is a bit confusing because the inline comments contradict the preceding explanation The documentation states that: 1. Static routes are always checked first. 2. Dynamic routes are checked in registration order. However, the example comments imply that `/posts/featured` is matched first because it was registered first, rather than because it is a static route. This PR updates the example to: - demonstrate that registration order only affects dynamic routes; - clarify that static routes always take precedence regardless of registration order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current "Route matching priority" example is a bit confusing because the inline comments contradict the preceding explanation
The documentation states that:
However, the example comments imply that
/posts/featuredis matched first because it was registered first, rather than because it is a static route.This PR updates the example to: